Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

📖 add OCI to infra provider list #6288

Merged
merged 1 commit into from
Mar 10, 2022
Merged

📖 add OCI to infra provider list #6288

merged 1 commit into from
Mar 10, 2022

Conversation

joekr
Copy link
Member

@joekr joekr commented Mar 10, 2022

What this PR does / why we need it:
Add the OCI infra provider to the providers list

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged):
No open issues related to this PR.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 10, 2022
@k8s-ci-robot
Copy link
Contributor

Hi @joekr. Thanks for your PR.

I'm waiting for a kubernetes-sigs member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Mar 10, 2022
killianmuldoon
killianmuldoon approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@killianmuldoon killianmuldoon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 10, 2022
@sbueringer
Copy link
Member

/lgtm

Assuming that it's intentionally only added to the doc and not yet to clusterctl.

@sbueringer
Copy link
Member

/retest

@fabriziopandini
Copy link
Member

Welcome 🥳 !
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 10, 2022
@fabriziopandini
Copy link
Member

/test pull-cluster-api-test-mink8s-main

@joekr
Copy link
Member Author

joekr commented Mar 10, 2022

@sbueringer

Assuming that it's intentionally only added to the doc and not yet to clusterctl.

Yes. We wanted to get it into the list and we are going to go work on getting it added to clusterctl next. 😊

@joekr
Copy link
Member Author

joekr commented Mar 10, 2022

/retest

@k8s-ci-robot
Copy link
Contributor

@joekr: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@sbueringer
Copy link
Member

/ok-to-test
/retest

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Mar 10, 2022
@k8s-ci-robot k8s-ci-robot merged commit dc20dfa into kubernetes-sigs:main Mar 10, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.2 milestone Mar 10, 2022
@joekr joekr deleted the add-cluster-api-oci-provider branch March 10, 2022 21:36
@joekr joekr mentioned this pull request Mar 10, 2022
Closed
@joekr joekr mentioned this pull request Jun 13, 2022
Closed
9 tasks
@sbueringer
Copy link
Member

/cherry-pick release-1.1

@k8s-infra-cherrypick-robot
Copy link

@sbueringer: #6288 failed to apply on top of branch "release-1.1":

Applying: add OCI to infra provider list
Using index info to reconstruct a base tree...
M	docs/book/src/reference/providers.md
Falling back to patching base and 3-way merge...
Auto-merging docs/book/src/reference/providers.md
CONFLICT (content): Merge conflict in docs/book/src/reference/providers.md
error: Failed to merge in the changes.
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Patch failed at 0001 add OCI to infra provider list
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".

In response to this:

/cherry-pick release-1.1

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@joekr joekr mentioned this pull request Jun 23, 2022
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@killianmuldoon killianmuldoon killianmuldoon approved these changes

@JoelSpeed JoelSpeed Awaiting requested review from JoelSpeed

@sbueringer sbueringer Awaiting requested review from sbueringer

Assignees

@sbueringer sbueringer

@fabriziopandini fabriziopandini

@killianmuldoon killianmuldoon

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
6 participants
@joekr @k8s-ci-robot @sbueringer @fabriziopandini @k8s-infra-cherrypick-robot @killianmuldoon